<html>
<head><meta charset="utf-8"><title>How to fix issues · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/How.20to.20fix.20issues.html">How to fix issues</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="222891460"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/How%20to%20fix%20issues/near/222891460" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/How.20to.20fix.20issues.html#222891460">(Jan 15 2021 at 17:16)</a>:</h4>
<p>Hey all - I've introduced a new lint in rustc (<a href="https://github.com/rust-lang/rust/pull/80723">https://github.com/rust-lang/rust/pull/80723</a>) which is causing some <a href="https://github.com/rust-lang/rust/pull/81032#issuecomment-760657370">tests to fail in clippy</a> and preventing a rollup. How do I go about fixing the issue?</p>



<a name="222893826"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/How%20to%20fix%20issues/near/222893826" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/How.20to.20fix.20issues.html#222893826">(Jan 15 2021 at 17:31)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> clippy is a subtree, so you can probably make any changes you need in src/tools/clippy directly</p>



<a name="222893855"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/How%20to%20fix%20issues/near/222893855" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/How.20to.20fix.20issues.html#222893855">(Jan 15 2021 at 17:31)</a>:</h4>
<p>(I don't know exactly what fixes you'd need)</p>



<a name="222898365"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/How%20to%20fix%20issues/near/222898365" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/How.20to.20fix.20issues.html#222898365">(Jan 15 2021 at 18:02)</a>:</h4>
<p>look at "diff of stdout" <a href="https://github.com/rust-lang-ci/rust/runs/1706561866#step:24:9333">here</a></p>



<a name="222898553"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/How%20to%20fix%20issues/near/222898553" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/How.20to.20fix.20issues.html#222898553">(Jan 15 2021 at 18:03)</a>:</h4>
<p>see where there are new warnings. probably just add <code>#![allow(new_lint)]</code> to the top of that test file</p>



<a name="222898722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/How%20to%20fix%20issues/near/222898722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/How.20to.20fix.20issues.html#222898722">(Jan 15 2021 at 18:04)</a>:</h4>
<p>but then you'll have to "bless" the output. Not sure if you can navigate to clippy folder and run <code>cargo dev bless</code></p>



<a name="222906621"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/How%20to%20fix%20issues/near/222906621" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/How.20to.20fix.20issues.html#222906621">(Jan 15 2021 at 18:55)</a>:</h4>
<p><span class="user-mention silent" data-user-id="360405">Cameron Steffen</span> <a href="#narrow/stream/257328-clippy/topic/How.20to.20fix.20issues/near/222898722">said</a>:</p>
<blockquote>
<p>but then you'll have to "bless" the output. Not sure if you can navigate to clippy folder and run <code>cargo dev bless</code></p>
</blockquote>
<p>not yet</p>



<a name="222908824"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/How%20to%20fix%20issues/near/222908824" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/How.20to.20fix.20issues.html#222908824">(Jan 15 2021 at 19:08)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> I left a comment: <a href="https://github.com/rust-lang/rust/pull/80723#issuecomment-761130918">https://github.com/rust-lang/rust/pull/80723#issuecomment-761130918</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>